Skip to content

feat: add back camera support #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 20, 2025

Conversation

thisisabhash
Copy link
Member

Issue #, if available:
None

Description of changes:
Back camera support for no light challenge

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash force-pushed the feat/no-light-support branch from bd97059 to 3557932 Compare June 17, 2025 18:35
@thisisabhash thisisabhash force-pushed the feat/back-camera-support branch from bf516df to 2ed0906 Compare June 17, 2025 19:55
@thisisabhash thisisabhash marked this pull request as ready for review June 17, 2025 20:03
@thisisabhash thisisabhash requested review from a team as code owners June 17, 2025 20:03
@thisisabhash thisisabhash merged commit 83e9e33 into feat/no-light-support Jun 20, 2025
4 checks passed
@thisisabhash thisisabhash deleted the feat/back-camera-support branch June 20, 2025 18:41
thisisabhash added a commit that referenced this pull request Jun 30, 2025
…#131)

* feat: add no light challenge implementation (#127)

* feat: add no light challenge implementation

* update package.swift for CI build

* Fix unit tests

* Address review comments

* chore: Add attempt count changes (#137)

* chore: Add attempt count changes

* Fix unit tests

* add unit tests

* Update region for example liveness view

* Update amplify-swift dependency

* chore: update dependencies after rebase

* fix: handle error on loading view (#154)

* chore: update amplify package dependency after rebase

* update Package.resolved files

* feat: add back camera support (#180)

* chore: back camera support

* Add code for error scenarios

* update error codes and message

* Add challengeOption parameter and remove error codes

* Update ChallengeOptions and use camera position based on challenge type received

* Add UI changes for selecting back camera in HostApp

* add default parameter to ChallengeOptions init

* fix formatting

* fix test build

* address review comments

* remove unused property

* update amplify dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants